-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Tags - Enable tag option is no longer grayed out after renaming tag offline. #43635
fix: Tags - Enable tag option is no longer grayed out after renaming tag offline. #43635
Conversation
…tag offline. Signed-off-by: Krishna Gupta <[email protected]>
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Signed-off-by: Krishna Gupta <[email protected]>
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-06-15.at.9.03.30.PM.movAndroid: mWeb Chrometesting.moviOS: Nativethis.moviOS: mWeb SafariScreen.Recording.2024-06-15.at.8.23.15.PM.movMacOS: Chrome / SafariScreen.Recording.2024-06-15.at.8.16.18.PM.movMacOS: DesktopScreen.Recording.2024-06-15.at.8.19.58.PM.mov |
@Krishna2323 , in testing steps can you please put a precondition that we need to have some tags added to the workspace , i will complete the checklist for now and then approve this PR after the testing steps are updated, thanks 🙏 |
@allgandalf, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, and tests well on all platforms 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks guys!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.85-0 🚀
|
2 similar comments
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.85-0 🚀
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.85-0 🚀
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀
|
Details
Fixed Issues
$ #42917
PROPOSAL: #42917 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4